Merged
Conversation
If a thread blocked waiting on a connection pool is interrupted, it's possible for the connection to become leaked if the pool then completes the future from its side. This commit prevents that from happening by intercepting the interrupt and attempting to cancel the lease future. If that is unsuccessful, the connection is returned to the upper, and the thread is reinterrupted. Adresses #6786
dagnir
added
the
no-api-surface-area-change
Contributor
Author
There's a change in |
dagnir
commented
Mar 31, 2026
...are/amazon/awssdk/http/apache5/internal/conn/SafePoolingHttpClientConnectionManagerTest.java
Show resolved
Hide resolved
alextwoods
reviewed
Apr 2, 2026
.../amazon/awssdk/http/apache5/internal/conn/SafePoolingHttpClientConnectionManagerBuilder.java
Show resolved
Hide resolved
...st/java/software/amazon/awssdk/http/apache5/internal/utils/CancelOnInterruptWrapperTest.java
Show resolved
Hide resolved
...est/java/software/amazon/awssdk/http/apache5/internal/utils/CancelOnInterruptFutureTest.java
Outdated
Show resolved
Hide resolved
RanVaknin
approved these changes
Apr 2, 2026
alextwoods
approved these changes
Apr 3, 2026
…ection-leak-interrupt
dagnir
force-pushed
the
dongie/apache5-connection-leak-interrupt
branch
from
20e5f72 to
3e80bdc
Compare
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
If a thread blocked waiting on a connection pool is interrupted, it's possible for the connection to become leaked if the pool then completes the future from its side.
This commit prevents that from happening by intercepting the interrupt and attempting to cancel the lease future. If that is unsuccessful, the connection is returned to the upper, and the thread is reinterrupted.
Adresses #6786
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License